[css-values-4] A small fix and some tweaks to calc serialization #11782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabatkins
reviewed
Feb 26, 2025
tabatkins
reviewed
Feb 26, 2025
|
Thanks! Sorry about those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully these are self-explanatory. I think they all count as editorial.
The numbering change is because it felt awkward to have non-numbered sequential steps in between an outer numbered list and an inner numbered list for Sum and Product nodes. But while I was at it, it made sense to also do that for Negate and Invert. Steps 2 and 3 feel simple enough that it's not necessary.
Closes #11781.