Skip to content

[css-text] force-hang end-of-line pre-wrap spaces before soft wraps #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[css-text] force-hang end-of-line pre-wrap spaces before soft wraps #3868

wants to merge 2 commits into from

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Apr 23, 2019

Closes #3440

@frivoal frivoal added the css-text-3 Current Work label Apr 23, 2019
@frivoal frivoal requested a review from fantasai April 23, 2019 07:00
@frivoal frivoal self-assigned this Apr 23, 2019
@frivoal frivoal mentioned this pull request Apr 23, 2019
Closed
@frivoal frivoal force-pushed the css-text-3440 branch 3 times, most recently from d1329cd to ed00938 Compare July 2, 2019 13:39
@frivoal
Copy link
Collaborator Author

frivoal commented Jul 2, 2019 •
edited
Loading

@fantasai Can you review this pull request? It is supposed to implement the changes resolved in #3440, but I want to make sure I'm not misunderstanding anything.

@kojiishi Can you also review this? In particular, please check the example, to make sure that what this does is in line with your understanding. Since reading the example in diff form is pretty annoying, here's a screenshot of what it looks like:
(Edited: I've updated the examples to show the same situations in both pull requests, this screenshot is therefore now obsolete. See next comment.).

@frivoal frivoal mentioned this pull request Jul 9, 2019
Merged
@frivoal
Copy link
Collaborator Author

frivoal commented Jul 27, 2019

Updated examples to show the same situations as in #4095 (only example 8 gives a different result):
Screen Shot 2019-07-27 at 14 18 30
Screen Shot 2019-07-27 at 14 18 35
Screen Shot 2019-07-27 at 14 18 40

@frivoal
Copy link
Collaborator Author

frivoal commented Sep 17, 2019

Closing. This was rejected, as #4095 was accepted instead.

@frivoal frivoal closed this Sep 17, 2019
@frivoal frivoal deleted the css-text-3440 branch September 17, 2019 08:16
@frivoal frivoal added Closed Accepted by CSSWG Resolution Testing Unnecessary Memory aid - issue doesn't require tests labels Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantasai fantasai Awaiting requested review from fantasai

Assignees

@frivoal frivoal

Labels
Closed Accepted by CSSWG Resolution css-text-3 Current Work Testing Unnecessary Memory aid - issue doesn't require tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-text][css-sizing] When to/not to include preserved trailing spaces
1 participant
@frivoal