Skip to content

Add @font-face descriptors for overriding font metrics #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 18, 2020

Conversation

xiaochengh
Copy link
Contributor

Following the resolution, this patch adds the following @font-face descriptors to CSS Fonts Level 4:

  • ascent-override: normal | <percentage>
  • descent-override: normal | <percentage>
  • line-gap-override: normal | <percentage>

@xiaochengh
Copy link
Contributor Author

Updated with all comments addressed. PTAL.

@fantasai
Copy link
Collaborator

I believe this would go into Fonts Level 5, though?

@xiaochengh
Copy link
Contributor Author

I don't have a strong opinion which level it should go into.

@tabatkins Could you advise?

@astearns
Copy link
Member

@alshamiri5 please stop spamming our PRs with reviews.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 18, 2020

I believe this would go into Fonts Level 5, though?

That spec doesn't yet exist and if created, would need to be a delta rather than a copy of fonts 4. Where it goes depends on how rapidly we get to consensus and get implementations. I could be persuaded either way.

I would be fine with merging this in fonts-4. We do after all have one implementation already :)

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating feedback to date. This LGTM.

@svgeesus
Copy link
Contributor

As both editors have approved, I'm going to go ahead and merge this. If it later turns out that this should be moved off to a Fonts 5 we can do that, along with any other featurs that are lagging on consensus or implementer uptake.

@xiaochengh thank you so much for the clear explanations, willingness to incorporate changes, and experimental implementation which all made this feature request super simple to get consensus around!

@svgeesus svgeesus merged commit 8f67f30 into w3c:master Sep 18, 2020
@xiaochengh
Copy link
Contributor Author

Thanks to everyone for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants