Skip to content

[css-images-4][css-backgrounds-4] Added stripes() function #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 5, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Made <color> and <1d-image> exclusive alternatives
  • Loading branch information
SebastianZ committed Oct 9, 2022
commit a49e0a28adc066aadd27b72d3740444ab925af9d
4 changes: 2 additions & 2 deletions css-backgrounds-4/Overview.bs
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ Painting Area: the 'background-clip' property</h3>

<pre class=propdef>
Name: border-top-color, border-right-color, border-bottom-color, border-left-color
Value: <<color>> || <<1d-image>>
Value: <<color>> | <<1d-image>>
Initial: currentcolor
Applies to: all elements
Inherited: no
Expand All @@ -196,7 +196,7 @@ Painting Area: the 'background-clip' property</h3>

<pre class="propdef shorthand">
Name: border-color
Value: [ <<color>> || <<1d-image>> ]{1,4}
Value: [ <<color>> | <<1d-image>> ]{1,4}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tabatkins @fantasai What do you think about my suggestion to distinguish the values for the different borders by adding slashes between them like in grid-area?

This makes the syntax more future proof, in my opinion.

Sebastian

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, here's the suggested syntax again:

<<color>>{1,4} | [ <<color>>? <<1d-image>>? ]! [ / [ <<color>>? <<1d-image>>? ]! ]{0,3}

And here's an example using that syntax:

border-color: stripes(white, silver) / stripes(white, silver) / stripes(black, gray) / blue;

</pre>

These properties set the foreground color of the border specified
Expand Down
2 changes: 1 addition & 1 deletion css-ui-4/Overview.bs
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ Animation type: by computed value

<pre class="propdef">
Name: outline-color
Value: [ <<color>> || <<1d-image>> ] | invert
Value: [ <<color>> | <<1d-image>> ] | invert
Initial: invert
Applies to: all elements
Inherited: no
Expand Down