Skip to content

[css-view-transitions-1] Update spec for resolved issues. #8058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2022
Merged

[css-view-transitions-1] Update spec for resolved issues. #8058

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8de8091
Update spec based on resolved issues
khushalsagar Nov 10, 2022
dfdc48f
Update Overview.bs
khushalsagar Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion css-view-transitions-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,8 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

Issue: The link for "paint order" doesn't seem right.
Is there a more canonical definition?

1. If any [=flat tree=] ancestor of this |element| [=skips its contents=], then [=continue=].

1. Let |transitionName| be the [=computed value=] of 'view-transition-name' for |element|.

Expand Down Expand Up @@ -706,6 +708,8 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

Issue: The link for "paint order" doesn't seem right.
Is there a more canonical definition?

1. If any [=flat tree=] ancestor of this |element| [=skips its contents=], then [=continue=].

1. Let |transitionName| be the [=computed value=] of 'view-transition-name' for |element|.

Expand Down Expand Up @@ -786,7 +790,13 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

Note: The ready promise would've been resolved if {{ViewTransition/skipTransition()}} is called after we start animating.

1. [=Reject=] |transition|'s [=ViewTransition/finished promise=] with |reason|.
1. [=promise/React=] to [=ViewTransition/DOM updated promise=]:

* If [=ViewTransition/DOM updated promise=] was resolved,
then [=resolve=] |transition|'s [=ViewTransition/finished promise=].

* If [=ViewTransition/DOM updated promise=] was rejected with reason |r|,
then [=reject=] |transition|'s [=ViewTransition/finished promise=] with |r|.
</div>

## [=Capture the image=] ## {#capture-the-image-algorithm}
Expand Down Expand Up @@ -1070,6 +1080,10 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
1. At the [=user-agent origin=],
set |new|'s 'object-view-box' property to a value that when applied to |new|,
will cause the view box to coincide with [=new element=]'s [=border box=] in the image.

This algorithm must be executed to update styles in [=user-agent origin=] if its effects can be observed by a web API.

Note: An example of such a web API is `window.getComputedStyle(document.documentElement, "::view-transition")`.
</div>

<div algorithm>
Expand Down