[css-view-transitions-1] Handling rendering constaints #8540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakearchibald
commented
Mar 7, 2023
jakearchibald
commented
Mar 7, 2023
khushalsagar
reviewed
Mar 7, 2023
khushalsagar
reviewed
Mar 7, 2023
|
Just the one suggestion above. Feel free to merge with that applied if you're happy with it. |
jakearchibald
commented
Apr 18, 2023
jakearchibald
commented
Apr 18, 2023
| @@ -593,7 +607,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; | |||
| This enables full customization of the transition. | |||
| </div> | |||
|
|
|||
| ### <dfn>::view-transition</dfn> | |||
| ### <dfn>::view-transition</dfn> ### {#::view-transition} | |||
There was a problem hiding this comment.
Just fixing some bikeshed errors while I'm here
jakearchibald
commented
Apr 18, 2023
Comment on lines
+1288
to
+1289
| 1. Let |namedElements| be |transition|'s [=ViewTransition/named elements=]. | ||
|
|
There was a problem hiding this comment.
Quick fix of something that was missed in an earlier refactor
khushalsagar
approved these changes
Apr 18, 2023
css-view-transitions-1/Overview.bs
Outdated
| @@ -497,6 +499,19 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; | |||
| This may be confusing, since the elements themselves are not necessarily referring to the same object, | |||
| but it is a useful model to consider them to be visual states of the same conceptual page entity, that we happen to call "element". | |||
|
|
|||
| # Layout and rendering changes # {#layout-rendering-changes} | |||
|
|
|||
| Both {{Element}}s and [=pseudo-elements=] have a <dfn>involved in a view transition</dfn>, a boolean. Initially false. | |||
There was a problem hiding this comment.
Nitty nit, feel free to ignore. :)
Suggested change
| Both {{Element}}s and [=pseudo-elements=] have a <dfn>involved in a view transition</dfn>, a boolean. Initially false. | |
| Both {{Element}}s and [=pseudo-elements=] have a boolean: <dfn>involved in a view transition</dfn>. Initially false. |
There was a problem hiding this comment.
Hmm, all other concept definitions in the spec are "name, a type. Initially value"
There was a problem hiding this comment.
Cool. If this is already a pattern in the spec, SGTM.
tabatkins
reviewed
Apr 18, 2023
Co-authored-by: Tab Atkins Jr. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8139
Fixes #7882
Depends on w3c/fxtf-drafts#507 - merged