-
Notifications
You must be signed in to change notification settings - Fork 711
[css-view-transitions-1] A few clarifications and nits #9028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Separated view transition activation to own algorithm, to prepare for cross-doc - Clarifying that new elements are invisible during the transition - Changed type of image from ImageData to 2D-bitmap - Fixed a few broken refs See w3c#8958
@fantasai FYI |
Co-authored-by: Khushal Sagar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial comments
@@ -787,6 +789,9 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; | |||
since that results in a circular dependency. | |||
Therefore, the [=view transition layer=] is a sibling of all other content. | |||
|
|||
When a {{Document}}'s [=document/active view transition=]'s [=ViewTransition/phase=] is "`animating`", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have both <code>
and quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm not familiar with the conventions here, so just asking.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. This spec uses <code>
for syntax which can be used by an author. phase is internal UA state.
* Effects applied on the element and its descendants, such as 'opacity' and 'filter', are applied to the capture. | ||
Effects applied to the element from its ancestors are ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is “Effects” as used here defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. Is there a definition in CSS for visual effects on an element which affect its descendants? The list here is the closest I've seen in documentation. I can also just add all these properties explicitly but nicer if we can have one definition to cross-reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9143 takes care of the remaining comments.
@@ -787,6 +789,9 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; | |||
since that results in a circular dependency. | |||
Therefore, the [=view transition layer=] is a sibling of all other content. | |||
|
|||
When a {{Document}}'s [=document/active view transition=]'s [=ViewTransition/phase=] is "`animating`", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. This spec uses <code>
for syntax which can be used by an author. phase is internal UA state.
* Effects applied on the element and its descendants, such as 'opacity' and 'filter', are applied to the capture. | ||
Effects applied to the element from its ancestors are ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. Is there a definition in CSS for visual effects on an element which affect its descendants? The list here is the closest I've seen in documentation. I can also just add all these properties explicitly but nicer if we can have one definition to cross-reference.
See #8958