Skip to content

add/revise popover related attribute mappings #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

add/revise popover related attribute mappings #481

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
39ae862
revise popover related attribute mappings
scottaohara May 9, 2023
e4694e5
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara May 9, 2023
9eed4ec
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara Jul 12, 2023
5fde9c0
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara Oct 4, 2023
cbd0cc6
Update index.html
scottaohara Oct 4, 2023
4cad167
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara Oct 12, 2023
e64eaae
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara Nov 7, 2023
0a3851e
update ia2/atk mappings
scottaohara Nov 22, 2023
5829073
Update index.html
scottaohara Nov 22, 2023
75d44ff
Update index.html
scottaohara Nov 22, 2023
4691b00
Update index.html
scottaohara Nov 22, 2023
ed8270a
Update index.html
scottaohara Dec 13, 2023
82b42e3
Update index.html
scottaohara Dec 13, 2023
2b36d6f
move details-roles:popover to correct attr table
scottaohara Dec 13, 2023
bfa65de
Update index.html
scottaohara Jan 9, 2024
bcdb24e
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara Feb 28, 2024
beccc2c
Update index.html
scottaohara Feb 28, 2024
ce1773d
Update index.html
scottaohara May 8, 2024
7ed1441
Update index.html
scottaohara May 8, 2024
1fde1de
Update index.html
scottaohara May 8, 2024
bf0a2fe
Update index.html
scottaohara May 8, 2024
fd42971
Update index.html
scottaohara May 8, 2024
5e31f10
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara May 8, 2024
44d2432
Update index.html
scottaohara May 8, 2024
71c0c0b
Update index.html
scottaohara May 8, 2024
fcdd9ac
Update index.html
scottaohara May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move details-roles:popover to correct attr table
  • Loading branch information
@scottaohara
scottaohara authored Dec 13, 2023
commit 2b36d6fbce3825d2332d9da7a202b4cdcd5ce9f5
23 changes: 12 additions & 11 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13594,7 +13594,6 @@ <h4 id=att-playsinline>`playsinline`</h4>
</tr>
</tbody>
</table>

<h4 id=att-popover>`popover`</h4>
<table aria-labelledby=att-poster>
<tbody>
Expand Down Expand Up @@ -13622,10 +13621,7 @@ <h4 id=att-popover>`popover`</h4>
<span class="type">Relations:</span> `IA2_RELATION_DETAILS_FOR` points to invoking element
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels weird that we express this as a platform specific relation, but we express popovertarget's details relation as a cross-platform aria-details relation. Is this just because we have no way of expressing reverse relations for ARIA mappings and we want to be explicit here? I wonder whether it'd be better to link to a more general note about implicit reverse relations or something like that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with either replacing the cross-platform aria-details relation with the specific platform mappings, or keeping the cross-platform relation and removing the platform specific and replacing with a note about the reverse relations.
over in #359 (which incase you missed, i pinged you for a review) we use the platform specific reverse relations for figure/figcaption. So we can do that here too, or similarly change over in that PR.

Whatever makes the most sense for those that need to read the spec is what I want to do, so just let me know which is preferred.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this shouldn't happen if we don't expose aria-details due to the invoking element being an immediate sibling or having popovertargetaction=hide? Again, hopefully common sense will prevail, but probably best not to rely on that.

<div class="objattrs">
<span class="type">Object attributes:</span>
<ul>
<li><code>ispopup: &lt;value></code> where <code>&lt;value></code> reflects the <a data-cite="html/popover.html#the-popover-attribute">popover</a> type</li>
<li>`details-roles:popover`</li>
</ul>
<code>ispopup: &lt;value></code> where <code>&lt;value></code> reflects the <a data-cite="html/popover.html#the-popover-attribute">popover</a> type</li>
</div>
</td>
</tr>
Expand All @@ -13638,13 +13634,12 @@ <h4 id=att-popover>`popover`</h4>
<tr>
<th><a href="https://gnome.pages.gitlab.gnome.org/atk/">ATK</a></th>
<td>
<span class="type">Relations:</span> `RELATION_DETAILS_FOR` points to invoking element
<p>
<span class="type">Relations:</span> `RELATION_DETAILS_FOR` points to invoking element
</p>
<div class="objattrs">
<span class="type">Object attributes:</span>
<ul>
<li><code>ispopup: &lt;value></code> where <code>&lt;value></code> reflects the <a data-cite="html/popover.html#the-popover-attribute">popover</a> type</li>
<li>`details-roles:popover`</li>
</ul>
<span class="type">Object attributes:</span>
<code>ispopup: &lt;value></code> where <code>&lt;value></code> reflects the <a data-cite="html/popover.html#the-popover-attribute">popover</a> type.
</div>
</td>
</tr>
Expand Down Expand Up @@ -13702,6 +13697,9 @@ <h4 id=att-popovertarget>`popovertarget`</h4>
+ <a href="http://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/">IAccessible2</a></th>
<td>
<div class="general">Use WAI-ARIA mapping</div>
<div class="general">
<span class="type">Object attributes:</span> `details-roles:popover`
</div>
</td>
</tr>
<tr>
Expand All @@ -13714,6 +13712,9 @@ <h4 id=att-popovertarget>`popovertarget`</h4>
<th><a href="https://gnome.pages.gitlab.gnome.org/atk/">ATK</a></th>
<td>
<div class="general">Use WAI-ARIA mapping</div>
<div class="general">
<span class="type">Object attributes:</span> `details-roles:popover`
</div>
</td>
</tr>
<tr>
Expand Down