-
Notifications
You must be signed in to change notification settings - Fork 18
Update URL when swithing the language in UI #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update URL when swithing the language in UI #262
Conversation
Hello @r12a could you review this one? thanks! |
@r12a could you add your review? I would like to add this fix in the final (I hope) update of JLReq. |
Yes, the latest editor's draft still has the buttons on the top-right corner. |
But the latest ED presumably doesn't include these changes(?) since they haven't been merged yet. To speed things up i'll mark this as accepted on the assumption that the buttons will still be there after merging. I took another look at the code, and it doesn't seem to affect the buttons. |
This patch changes to update the URL search parameters when switching the language in UI. This change can ensure the URL can navigate to what the user is seeing.
10fdb5e
to
d109d3c
Compare
Thanks for the approval. I rebased to the ToT and confirmed it's still working. I was actually a bit scary because the original patch was 3 years ago ;-) |
Update URL when swithing the language in UI
This patch changes to update the URL search parameters when
switching the language in UI. This change can ensure the URL
can navigate to what the user is seeing.
Fixes #236.