Skip to content

turn half-em to half em (except for existing links and anchors) #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2021
Merged

turn half-em to half em (except for existing links and anchors) #300

merged 1 commit into from
Sep 3, 2021

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Sep 2, 2021 •
edited by pr-preview bot
Loading

closes #237

Preview | Diff

@himorin himorin requested review from r12a and kidayasuo September 2, 2021 09:01
r12a
r12a approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macnmm said

half-em is adjectival; half em is nominal

If we applied that thinking, then i believe these are adjectival instances. But to be honest, i don't feel strongly enough about this to object. So ok by me.

kidayasuo
kidayasuo approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@kidayasuo kidayasuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. thanks!

@himorin himorin merged commit 1665e14 into w3c:gh-pages Sep 3, 2021
deniak pushed a commit that referenced this pull request Mar 24, 2025
@himorin
Merge pull request #300 from himorin/issue-237
a32e9a6 
turn half-em to half em (except for existing links and anchors)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r12a r12a r12a approved these changes

@kidayasuo kidayasuo kidayasuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two instances of "half-em" are used while majority usage is "half em"
3 participants
@himorin @r12a @kidayasuo