-
Notifications
You must be signed in to change notification settings - Fork 18
Merge English and Japanese glossaries into one #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since PR Preview failed to build, people who would like to see the preview can go to https://raw.githack.com/w3c/jlreq/xfq/merge-glossary/index.html#appendix_7 |
@kidayasuo this PR is which I've mentioned in today's F2F. |
I think we should translate the word "Transliteration" in the header into Japanese before merging this PR, at least. (Suggestions are welcome.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving the PR. Thank you for doing the merge!
I think "よみ" as current separated version is fine.
I'd close #59 and add new PR for that after this merged (I can work). For #75 and #87, yes, we need to deal with after this merged. |
Thanks @himorin. I updated the PR. |
@xfq what's the outlook for you to build in the other PR changes mentioned above and merge this? |
@r12a Sorry, I'm not sure I understand what you mean. Would you please explain? |
Sorry about that. Let me try again: How soon will we merge this pull request? And will you add to it the fixes for the other PRs mentioned in #88 (comment) ? |
Since I have three r+ now, I'll go ahead and merge this PR, and:
Thanks for the review! |
Fix #60 using the method in #60 (comment)
Two things I haven't done yet:
IMO the second point can be done after the merge.
Preview | Diff