Skip to content

PresentationRequest constructor uses entry settings object, but it probably shouldn't #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smaug---- opened this issue Sep 1, 2016 · 4 comments
Labels

Comments

@smaug----
Copy link

See https://html.spec.whatwg.org/multipage/webappapis.html#realms-settings-objects-global-objects
"The incumbent and entry concepts should not be used by new specifications, as they are excessively complicated and unintuitive to work with."

@anssiko anssiko added the v1 label Sep 7, 2016
@tidoust
Copy link
Member

tidoust commented Sep 26, 2016

See discussion at TPAC

PROPOSED RESOLUTION: For #336, examine how other specs have been updated to use the settings object and update our spec to match.

@domenic
Copy link

domenic commented Sep 27, 2016

You want current settings object here. Quoting from the link in the OP,

In general, web platform specifications should use the relevant concept, applied to the object being operated on (usually the this value of the current method). This mismatches the JavaScript specification, where current is generally used as the default (e.g. in determining the JavaScript realm whose Array constructor should be used to construct the result in Array.prototype.map). But this inconsistency is so embedded in the platform that we have to accept it going forward.

Note that in constructors, where there is no this value yet, the current concept is the appropriate default.

@markafoltz
Copy link
Contributor

OK. What is the relationship between the current settings object and the environment settings object for a given function invocation in a document? The settings object properties needed to implement the algorithms (API base URL and https state) are defined on the latter, not the former.

@domenic
Copy link

domenic commented Sep 29, 2016

"the environment settings object for a given function invocation in a document?"

This concept does not exist. Function invocations are not spec objects which can have environment settings objects belonging to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants