Replace DOMString with USVString for PresentationRequest URLs. #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @annevk who requested the change. |
markafoltz
changed the title
|
Reverted the ID change. (It seems unlikely that a unique ID generated by the browser will have a lone surrogate, but let's make that a separate issue.) |
|
Is the ID transmitted over the wire or serialized in some way? In that case USVString might make sense. |
|
Yes, it needs to be serializable as it can be sent to a separate receiving user agent over the network. UTF-8 can encode lone surrogates, but we don't require that, so that sounds like a reason for using USVString to provide more flexibility. |
|
UTF-8 cannot encode lone surrogates. So yes, you should use USVString. |
This reverts commit d342ba9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #361: Use USVString for URLs.