Skip to content

Addresses Issue 367 #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2016
Merged

Addresses Issue 367 #395

merged 3 commits into from
Dec 20, 2016

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Dec 19, 2016

Addresses Issue #367: Well defined environment for nested contexts of the receiving browsing context?

This applies the restrictions placed on the receiving browsing context to child browsing contexts of that context. It also clarifies that navigator.presentation.receiver should be null in those contexts.

Please check my terminology :)

Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this rather addresses issue #367, not issue #387.

See inline for a couple of minor comments. LGTM otherwise.

"https://www.w3.org/TR/html5/browsers.html#nested-browsing-contexts">nested
browsing context</a></dfn>, and <dfn><a href=
"https://www.w3.org/TR/html51/browsers.html#list-of-the-descendant-browsing-contexts">
list of descendent browsing contexts</a></dfn>, and <dfn><a href=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/descendent/descendant
(same typo to fix in the algorithm that references that notion)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

"creating a new browsing context">created</a> by the presented
document, i.e. that have the <a>receiving browsing context</a> as
their <a data-lt="ancestor browsing context">top-level
ancestor</a>, MUST also have restrictions 2-4 above. All of these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the definition of top-level browsing context in HTML, I believe you can simply say "their top-level browsing context" here and drop the reference to "ancestor browsing context" (and drop it from the list of terms too).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@markafoltz markafoltz changed the title Addreses Issue 387 Addresses Issue 387 Dec 20, 2016
@markafoltz markafoltz merged commit f2f4fee into gh-pages Dec 20, 2016
@markafoltz markafoltz changed the title Addresses Issue 387 Addresses Issue 367 Dec 20, 2016
@markafoltz markafoltz deleted the issue-387-receiving-contexts branch December 20, 2016 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants