Sets top-level navigation and modal dialog flags on presentations. #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks! |
tidoust
reviewed
Mar 1, 2017
index.html
Outdated
| response to a call to <code>window.close()</code> in the | ||
| <a>top-level browsing context</a> or to a request to | ||
| <a>navigate</a> that context to a new resource. | ||
| response a request to <a>navigate</a> that context to a new |
There was a problem hiding this comment.
s/in response a request/in response to a request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #414: Receiving browsing context needs additional flags set.
It sets the sandboxed top-level navigation browsing context flag and sandboxed modals flag on the receiving browsing context, to protect the integrity of the origin being presented, and to reflect implementation behavior (pending Mozilla feedback).
It also drops a reference to calling
window.close(), as this is not allowed with the former flag set. Instead, the presentation must callconnection.terminate()on anyPresentationConnection.