Skip to content

Typo: Change all instances of dismissable to dismissible #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025

Conversation

patrickhlauke
Copy link
Member

This is a clean redo of #4265 (which seems to have some unforeseen additional changes)

This is a clean redo of #4265 (which seems to have some unforeseen additional changes)
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit d9adcc3
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/681a3cc9fe67c60008b19720
😎 Deploy Preview https://deploy-preview-4292--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patrickhlauke
Copy link
Member Author

Setting this already to "Ready for approval", as we agreed to the original #4265 (before we spotted that that PR wasn't clean)

@mbgower
Copy link
Contributor

mbgower commented Apr 23, 2025

@kfranqueiro can we remove the json file from this now?

@kfranqueiro
Copy link
Contributor

@kfranqueiro can we remove the json file from this now?

Thanks for flagging, @mbgower, I've just synced with main and yes that means wcag.json is already removed. The next time we perform a site build, the update made to the Understanding document should propagate to the generated JSON.

@mbgower mbgower merged commit 3ed8495 into main May 6, 2025
1 check passed
@mbgower mbgower deleted the patrickhlauke-pr4265-clean-redo branch May 6, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants