Parse and validate URL template at manifest parse time #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgiuca
force-pushed
the
parse-at-parse-time
branch
2 times, most recently
from
7de4872 to
3d3fc8b
Compare
mgiuca
force-pushed
the
parse-at-parse-time
branch
from
3d3fc8b to
dd67553
Compare
|
@ewilligers PTAL. This is the main change I want to make to this spec before sending back to TAG review. |
|
Add resolves #25 to the CL description. |
ewilligers
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the URL template would be stored as an opaque string until target launch time, at which point any syntax errors in the template would result in a failed launch.
Now, the URL template is parsed at manifest parse time, and stored as a URL object. Any syntax errors (URL syntax or template syntax) result in the target being ignored in any share picker.
Resolves #25.
Preview | Diff