files members should be a sequence, not a FrozenArray #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

marcoscaceres opened this issue Jul 9, 2020 · 1 comment · Fixed by #170

Member

marcoscaceres commented Jul 9, 2020

When passing dictionaries as arguments, FrozenArray doesn't make much sense, as:

dictionaries are passed by value
it implies that dictionary.files = Array.freeze([...files]);, which is really what is mean there.

Related discussion whatwg/webidl#900

The text was updated successfully, but these errors were encountered:

marcoscaceres mentioned this issue

What does FrozenArray mean in dictionaries? whatwg/webidl#900

Closed

Collaborator

ewilligers commented Jul 30, 2020

I have no concerns.

Chromium change would be trivial.

marcoscaceres mentioned this issue

User a sequence for files #170

Merged

4 tasks

marcoscaceres closed this as completed in #170

blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this issue


          WebShare: navigator.share() uses files sequence

ffe2000

As discussed in github, the ShareData dictionary now contains a
sequence instead of a FrozenArray.
w3c/web-share#165

Bug: 1112600
Change-Id: I58238f36158902ddcacf228ab32cd3ffbffdf2a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327774
Commit-Queue: Eric Willigers <[email protected]>
Auto-Submit: Eric Willigers <[email protected]>
Reviewed-by: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#795382}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment