Skip to content

Demo: Disable buttons during share #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

ewilligers
Copy link
Collaborator

While the promise has not yet resolved or rejected, we disable
the share button to prevent additional share attempts.

This avoids confusion arising from
[[sharePromise]] internal slot (#113)

While the promise has not yet resolved or rejected, we disable
the share button to prevent additional share attempts.

This avoids confusion arising from
[[sharePromise]] internal slot (w3c#113)
@ewilligers ewilligers requested a review from mgiuca January 12, 2021 09:39
@ewilligers
Copy link
Collaborator Author

Copy link

@phoglenix phoglenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though I'm not officially a contributor on this project) 😃

@ewilligers ewilligers merged commit 6685668 into w3c:master Jan 20, 2021
@ewilligers ewilligers deleted the disable-buttons branch January 20, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants