Skip to content

Define sharable scheme + check #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 7, 2022
Merged

Define sharable scheme + check #244

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d95dd15
Define sharable scheme + check
marcoscaceres Jul 1, 2022
277339c
fixup: s/ol/ul
marcoscaceres Jul 1, 2022
fad97d5
Clean up Priv/Sec to match
marcoscaceres Jul 1, 2022
6af96aa
remove data
marcoscaceres Jul 1, 2022
2f73158
Explicitly ban file, javascript, wss, local scheme
marcoscaceres Jul 1, 2022
2d9438a
Update index.html
marcoscaceres Jul 1, 2022
a634c92
Merge branch 'main' into schemes
marcoscaceres Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update index.html
  • Loading branch information
@marcoscaceres
marcoscaceres authored Jul 1, 2022
commit 2d9438a136ef4c03d0bd92da5fc61480de827c1f
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ <h3>
<li>If |url| is failure, return false.
</li>
<li>If the |url|'s [=URL/scheme=] is a [=local scheme=], or
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this check is kinda redundant, because they are not in the the "sharable scheme" list, but I wanted to be explicit in banning them.

`file`, or `javascript`, or `wss`, return false.
`file`, or `javascript`, or `ws`, or `wss`, return false.
</li>
<li>If |url|'s [=URL/scheme=] is not a [=sharable scheme=],
return false.
Expand Down