Make Permissions-Policy HTTP header OPTIONAL #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomayac
reviewed
Feb 23, 2023
Co-authored-by: Thomas Steiner <[email protected]>
|
Thanks @tomayac! |
An editorial fix (the word "issues" was implied but missing), and rewrite last sentence of future spec expectations to improve grammar, remove use of a passive "mandatory" phrase. Feel free to revise that sentence further.
tantek
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
I made a change which I thought would show up as a suggested commit to fix an editorial issue and rewrite the last sentence of the aside note for readability. The rest of this edit looks good. Please review the edits I made to see if they reflect the intent of this PR.
|
Leaving the tests alone for this and left links to the relevant spec bugs for the HTTP headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @tantek - to address Formal Objection.
For normative changes, the following tasks have been completed:
Implementation commitment:
Preview | Diff