-
Notifications
You must be signed in to change notification settings - Fork 67
Miscellaneous spec cleanup (no normative changes) #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
05ed5d6
Link to promise spec.
mgiuca 786a14a
Explicitly resolve promise with undefined.
mgiuca 2cc5c61
Make the share method steps a MUST.
mgiuca 85d5186
Added normative requirement to not reveal the targets to the website.
mgiuca 9e8d108
Rewrite some non-normative text to remove MUST and MUST NOT language.
mgiuca 61b6b8d
Revert "Make the share method steps a MUST."
mgiuca a94067a
Link resolve and reject to promises spec.
mgiuca 9395223
Rewrite to avoid using RFC2119 keywords in non-normative text.
mgiuca 2cbfd0e
Explain that additional private browsing restrictions are not mandated.
mgiuca b658e25
Be more specific about getting the base URL.
mgiuca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Rewrite to avoid using RFC2119 keywords in non-normative text.
- Loading branch information
commit 9395223e0e4477cb1e338632b216392a0de8306f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introduction still contains "should", and seems out of place since this is supposed to be now re-stating requirements expressed elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I've grepped the whole document for all reserved words in RFC 2119 and rewritten the sentences around them (or, in one case, upgraded "may" to "MAY").