fix: ReSpec link warnings #54

marcoscaceres · 2017-11-27T02:04:59Z

marcoscaceres · 2017-11-27T02:06:16Z

We should probably define the errors in a dependencies section, as it would clean up quite a bit of markup.

Let me know if you want me to do that...

Also, should "en-US" a few words 😱, as eventually we will need to do that for w3c (requirement that documents be in US English).

marcoscaceres · 2017-11-27T02:07:21Z

index.html

        <h3>
          <code>Navigator</code> interface
        </h3>
        <p>
-          The <code><dfn data-cite="!HTML#navigator">Navigator</dfn></code>
-          interface is defined in [[!HTML]].
+          The <dfn data-cite="!HTML#navigator">Navigator</dfn> interface is


woopsy, this one was fine.

marcoscaceres · 2017-11-27T02:08:22Z

Found a few other little things to fix... brb

marcoscaceres · 2017-11-27T02:29:41Z

OK, should be all good now for review :)

marcoscaceres · 2017-11-27T02:34:00Z

index.html

            USVString url;
          };
        </pre>
        <p>
          The <dfn>ShareData</dfn> dictionary consists of several optional
-          fields:
+          members:


In the spec, you use "fields" throughout... but in IDL, I think these are called members.

Will file a separate bug for this.

mgiuca

We should probably define the errors in a dependencies section, as it would clean up quite a bit of markup.

Let me know if you want me to do that...

I'm not quite sure what you mean (is it just adding an errors section to the end so I don't have to write long hrefs?). Go ahead and do it in this CL if you think it helps and is easy. I'm also happy to keep it as-is.

mgiuca · 2017-11-27T02:45:49Z

index.html

-            When the <dfn>share</dfn> method is called with argument
-            <var>data</var>, run the following steps:
+            When the <a>share()</a> method is called with argument
+            <a>ShareData</a> <var>data</var>, run the following steps:


I don't think this needs to say ShareData here (it seems very unconventional to specify a data type when defining an argument to an algorithm).

Np. I'll remove that. I've seen it as a trend I think in the WHATWG specs.

marcoscaceres · 2017-11-27T03:47:04Z

index.html

-                  p</var> with <a data-cite=
-                  "!WEBIDL#aborterror"><code>AbortError</code></a>, and abort
-                  these steps.
+                  p</var> with "<a>AbortError</a>" <a>DOMException</a>, and


Clarified that "AbortError" isn't an error class, it's a DOMException type. Same with "NotAllowedError".

Cool. Can you be consistent with NotAllowedError and say "an "AbortError" DOMException" (i.e., add "an" in front of AbortError).

marcoscaceres · 2017-11-27T03:53:37Z

I'm not quite sure what you mean (is it just adding an errors section to the end so I don't have to write long hrefs?). Go ahead and do it in this CL if you think it helps and is easy. I'm also happy to keep it as-is.

Added Dependencies section with links to the various common IDL things. Can probably leave the rest, as everything links directly into the WebIDL spec.

mgiuca

Thanks. I wrote a few comments.

mgiuca · 2017-11-27T03:51:38Z

index.html

-                  p</var> with <a data-cite=
-                  "!WEBIDL#aborterror"><code>AbortError</code></a>, and abort
-                  these steps.
+                  p</var> with "<a>AbortError</a>" <a>DOMException</a>, and


Cool. Can you be consistent with NotAllowedError and say "an "AbortError" DOMException" (i.e., add "an" in front of AbortError).

mgiuca · 2017-11-27T03:51:50Z

index.html

-                  p</var> with <a data-cite=
-                  "!WEBIDL#aborterror"><code>AbortError</code></a>, and abort
-                  these steps.
+                  p</var> with "<a>AbortError</a>" <a>DOMException</a>, and


mgiuca · 2017-11-27T03:51:55Z

index.html

-                  p</var> with <a data-cite=
-                  "!WEBIDL#aborterror"><code>AbortError</code></a>, and abort
-                  these steps.
+                  p</var> with "<a>AbortError</a>" <a>DOMException</a>, and


mgiuca · 2017-11-27T03:52:05Z

index.html

            USVString url;
          };
        </pre>
        <p>
          The <dfn>ShareData</dfn> dictionary consists of several optional
-          fields:
+          members:


mgiuca · 2017-11-27T03:52:30Z

index.html

+        </li>
+        <li>
+          <code><dfn data-cite=
+          "!WEBIDL#notallowederror">NotAllowedError</dfn></code>.


Remove the period at the end here. (Or add periods to all of them.)

mgiuca · 2017-11-27T03:53:21Z

index.html

+      <ul data-sort="">
+        <li>
+          <code><dfn data-cite=
+          "!WEBIDL#exceptiondef-typeerror">TypeError</dfn></code>


I wonder if we could instead link to https://tc39.github.io/ecma262/#sec-native-error-types-used-in-this-standard-typeerror which is where TypeError is actually defined? WebIDL just refers to that. Maybe web specs don't normally directly link to ECMA-262. This is fine also.

marcoscaceres · 2017-11-27T04:01:33Z

Hopefully all good now :)

marcoscaceres · 2017-11-27T04:04:52Z

oooh... hang on.... broke something...

marcoscaceres · 2017-11-27T04:07:40Z

Better 🤪

marcoscaceres · 2017-11-27T04:26:48Z

Ok, if you are good with this, please merge.

Spec is looking really good btw! Really easy to read and follow.

Any plans to migrate this to a W3C WG? Mozilla aside, have you gotten any interest from the folks at Microsoft?

mgiuca · 2017-11-28T06:43:42Z

index.html

            USVString text;
+            USVString title;


Hmm, why did the order change? Are you just making it alphabetical? I'd prefer to keep it in order title > text > url, since that's the order I think developers should supply them if supplying them all. (That's the order that a receiver will normally display them.)

(Note that WebIDL dictionaries don't care what the order is, so this decision isn't normative, just presentational.)

Ping? @marcoscaceres

ah, sorry... just saw this... was alphabetical, will revert.

mgiuca · 2017-11-28T07:03:40Z

Any plans to migrate this to a W3C WG?

I think if Mozilla is going to implement then it makes sense to move this out of WICG. Do you have a proposed WG?

have you gotten any interest from the folks at Microsoft?

No, not lately. I will ping them again.

marcoscaceres · 2017-11-28T08:24:32Z

Either Web Platform WG or the new Device APIs WG (cc @anssiko), where the original work on Web Intents took place IIRC.

marcoscaceres · 2017-11-29T03:08:35Z

@mgiuca, can we merge?

marcoscaceres · 2017-11-29T03:11:46Z

Ok, put USVString title; back at top :)

mgiuca · 2017-11-30T02:03:43Z

Great, thanks!

fix: ReSpec link warnings

99ae344

marcoscaceres requested a review from mgiuca November 27, 2017 02:06

marcoscaceres commented Nov 27, 2017

View reviewed changes

fix few additional things

067b878

Remove redundant data-link-for

6f08f69

marcoscaceres commented Nov 27, 2017

View reviewed changes

mgiuca approved these changes Nov 27, 2017

View reviewed changes

marcoscaceres added 2 commits November 27, 2017 14:10

Address review feedback

ecd0108

Fixup exceptions

686ec24

marcoscaceres commented Nov 27, 2017

View reviewed changes

mgiuca reviewed Nov 27, 2017

View reviewed changes

Fix more nits

9fda45d

fix typo

69353ae

fix ECMASCRIPT citation

d6d7bb2

mgiuca reviewed Nov 28, 2017

View reviewed changes

anssiko mentioned this pull request Nov 28, 2017

Adopt Web Share API? w3c/das-charter#57

Closed

Revert ordering of USVString title

9c2b429

mgiuca merged commit 2ce56e5 into master Nov 30, 2017

marcoscaceres deleted the linkin branch November 30, 2017 02:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ReSpec link warnings #54

fix: ReSpec link warnings #54

marcoscaceres commented Nov 27, 2017 •

edited by pr-preview bot

Loading

marcoscaceres commented Nov 27, 2017

marcoscaceres Nov 27, 2017

marcoscaceres commented Nov 27, 2017

marcoscaceres commented Nov 27, 2017

marcoscaceres Nov 27, 2017

marcoscaceres Nov 27, 2017

mgiuca Nov 27, 2017

mgiuca left a comment

mgiuca Nov 27, 2017

marcoscaceres Nov 27, 2017

marcoscaceres Nov 27, 2017

mgiuca Nov 27, 2017

marcoscaceres commented Nov 27, 2017

mgiuca left a comment

mgiuca Nov 27, 2017

mgiuca Nov 27, 2017

mgiuca Nov 27, 2017

mgiuca Nov 27, 2017

mgiuca Nov 27, 2017

mgiuca Nov 27, 2017

marcoscaceres commented Nov 27, 2017

marcoscaceres commented Nov 27, 2017

marcoscaceres commented Nov 27, 2017

marcoscaceres commented Nov 27, 2017

mgiuca Nov 28, 2017

mgiuca Nov 29, 2017 •

edited

Loading

marcoscaceres Nov 29, 2017

mgiuca commented Nov 28, 2017

marcoscaceres commented Nov 28, 2017

marcoscaceres commented Nov 29, 2017

marcoscaceres commented Nov 29, 2017

mgiuca commented Nov 30, 2017

fix: ReSpec link warnings #54

fix: ReSpec link warnings #54

Conversation

marcoscaceres commented Nov 27, 2017 • edited by pr-preview bot Loading

marcoscaceres commented Nov 27, 2017

Choose a reason for hiding this comment

marcoscaceres commented Nov 27, 2017

marcoscaceres commented Nov 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgiuca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcoscaceres commented Nov 27, 2017

mgiuca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcoscaceres commented Nov 27, 2017

marcoscaceres commented Nov 27, 2017

marcoscaceres commented Nov 27, 2017

marcoscaceres commented Nov 27, 2017

Choose a reason for hiding this comment

mgiuca Nov 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgiuca commented Nov 28, 2017

marcoscaceres commented Nov 28, 2017

marcoscaceres commented Nov 29, 2017

marcoscaceres commented Nov 29, 2017

mgiuca commented Nov 30, 2017

marcoscaceres commented Nov 27, 2017 •

edited by pr-preview bot

Loading

mgiuca Nov 29, 2017 •

edited

Loading