Drop most CSS value spaces duplicates #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the same logic as for CSS properties to drop duplicates from CSS extracts. Some duplicates remain: `<fit-content()>`, `<length>`, `<path()>`, `<percentage>`, `<rect()>` and `<url>`. No easy way to get rid of them, as functions and terms seem to be reused on purpose with similar though slightly different meaning each time. These duplicates are hardcoded into tests. No update to guarantees in README as it's not clear what interesting guarantees we can really make for now. Value spaces remain too messy to be directly usable, e.g. see #127 (comment)
|
Taking the liberty to merge to release a somewhat consistent CSS package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same logic as for CSS properties to drop duplicates from CSS extracts. Some duplicates remain:
<fit-content()>,<length>,<path()>,<percentage>,<rect()>and<url>.No easy way to get rid of them, as functions and terms seem to be reused on purpose with similar though slightly different meaning each time. These duplicates are hardcoded into tests.
No update to guarantees in README as it's not clear what interesting guarantees we can really make for now. Value spaces remain too messy to be directly usable, e.g. see #127 (comment)