Skip to content

Conversation

@og118
Copy link
Contributor

@og118 og118 commented Feb 12, 2024

  • Setup Tailwind css for blogs and docs page
  • Changed the theme for the docs/blogs page and tried to match it with the rest of the app.

Screenshots of the new docs/blog page:
Light Mode:
image
Dark Mode:
image

The colors do not match perfectly, and I needed help deciding the color palette for tailwind and starlight (added a comment for the same) @vincanger

Addresses #7

theme: {
extend: {
colors: {
accent: yellow, gray
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I needed input on what color palette should be used.

As per starlight docs,
accent determines the colors of links, active nav items, etc.
gray determines the color of background in both dark and light modes

Currently, I assigned them to pure yellow and grey palletes that come along with tailwind.

const yellow: {
    '50': "#fefce8";
    '100': "#fef9c3";
    '200': "#fef08a";
    '300': "#fde047";
    '400': "#facc15";
    '500': "#eab308";
    '600': "#ca8a04";
    '700': "#a16207";
    '800': "#854d0e";
    '900': "#713f12";
    '950': "#422006";
}

and,

gray: {
    '50': "#f9fafb";
    '100': "#f3f4f6";
    '200': "#e5e7eb";
    '300': "#d1d5db";
    '400': "#9ca3af";
    '500': "#6b7280";
    '600': "#4b5563";
    '700': "#374151";
    '800': "#1f2937";
    '900': "#111827";
    '950': "#030712";
}

Copy link
Collaborator

@vincanger vincanger Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked it out @og118 and it looks great! let's go with the defaults 🤝

and it looks ready to merge, that is if you're finished working on it.

@og118 og118 marked this pull request as draft February 12, 2024 08:53
@Martinsos
Copy link
Member

Martinsos commented Feb 12, 2024

Wow nice @og118 !

@vincanger is the best person to take a look -> it might take him a couple of days to take a look because he is traveling though!

@og118 og118 marked this pull request as ready for review February 17, 2024 13:22
@og118
Copy link
Contributor Author

og118 commented Feb 17, 2024

Hi @vincanger, I'm done with the changes and have reviewed and tested the changes on my end.
However, one thing that bugs me is that the PR shows a whopping 1240 lines of added code because of the autogenerated package.lock, should I remove it from the changes?

@vincanger
Copy link
Collaborator

That’s fine @og118 !

I’ll check this PR out tomorrow when I’m back at my laptop but from what I can see now it looks ready to merge. Great work and thanks so much for your contribution 🙏

@vincanger
Copy link
Collaborator

Oh yes, looking sweet. Thanks so much for your contribution here @og118! Much appreciated

@vincanger vincanger merged commit ba461b4 into wasp-lang:main Feb 20, 2024
vincanger pushed a commit that referenced this pull request Feb 20, 2024
@vincanger
Copy link
Collaborator

@og118 😍
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants