[document-conversion] Adds index document API #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the index_document API for the document conversion service.
|
|
|
@nfriedly do we get |
|
This looks OK for me |
|
@germanattanasio we have the ESLlint rule disabled but we do run the doc build on travis as part of the tests and it looks like this one passed |
|
Hey @samir-patel, sorry it took me a couple of days to get to this; do you think you can add a basic "happy case" unit test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This submission includes new API call for the Document Conversion Service that will allow you to access the index_document endpoint:
DocumentConversion.prototype.index
This is a synchronous call that will allow you to convert and index a document into a SOLR collection (via the Retrieve and Rank service) in one operation. A "dry run" of the indexing can be submitted to preview the indexed results prior to actual indexing.