Skip to content

Array Query Params #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 14, 2017
Merged

Array Query Params #592

merged 5 commits into from
Dec 14, 2017

Conversation

ammardodin
Copy link
Contributor

@ammardodin ammardodin commented Dec 12, 2017

Some of the services only pickup the first instance of a query parameter if it's repeated multiple times in the query string, i.e. &return=foo&return=bar. This PR unifies the behavior so that we're always sending a comma separated value, i.e &return=foo,bar.

@ammardodin ammardodin merged commit 54e1e7c into master Dec 14, 2017
@ammardodin ammardodin deleted the array-query-params branch December 14, 2017 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant