feat: regenerated sdks with new discovery credentials operations #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
========================================
- Coverage 84.09% 84% -0.09%
========================================
Files 35 35
Lines 4325 4389 +64
Branches 548 553 +5
========================================
+ Hits 3637 3687 +50
- Misses 319 323 +4
- Partials 369 379 +10
Continue to review full report at Codecov.
|
germanattanasio
previously requested changes
Jul 12, 2018
There was a problem hiding this comment.
@dpopp07 we need to add unit tests for all the new method. We are relying too much on integration tests. Everything else looks good.
mediumTaj
reviewed
Jul 12, 2018
language-translator/v2-generated.ts
Outdated
| * IBM Watson™ Language Translator translates text from one language to another. The service offers multiple domain-specific models that you can customize based on your unique terminology and language. Use Language Translator to take news from across the globe and present it in your language, communicate with your customers in their own language, and more. | ||
| * | ||
| * @deprecated Language Translator v3 is now available. The v2 Language Translator API will no longer be available after July 31, 2018. To take advantage of the latest service enhancements, migrate to the v3 API. View the [Migrating to Language Translator v3](https://console.bluemix.net/docs/services/language-translator/migrating.html) page for more information. | ||
| * --- Language Translator v3 is [available](https://www.ibm.com/watson/developercloud/language-translator/api/v3/). See the [migration guide](https://console.bluemix.net/docs/services/language-translator/migrating.html). --- IBM Watson™ Language Translator translates text from one language to another. The service offers multiple domain-specific models that you can customize based on your unique terminology and language. Use Language Translator to take news from across the globe and present it in your language, communicate with your customers in their own language, and more. |
There was a problem hiding this comment.
Will this line still show deprecation message for LTv2?
There was a problem hiding this comment.
Probably not, I'll fix that and add it to the post-generation notes
mediumTaj
reviewed
Jul 12, 2018
language-translator/v3.ts
Outdated
| @@ -40,7 +40,7 @@ class LanguageTranslatorV3 extends BaseService { | |||
| * @param {string} [options.password] - The password used to authenticate with the service. Username and password credentials are only required to run your application locally or outside of Bluemix. When running on Bluemix, the credentials will be automatically loaded from the `VCAP_SERVICES` environment variable. | |||
| * @param {string} [options.iam_access_token] - An IAM access token fully managed by the application. Responsibility falls on the application to refresh the token, either before it expires or reactively upon receiving a 401 from the service, as any requests made with an expired token will fail. | |||
| * @param {string} [options.iam_apikey] - An API key that can be used to request IAM tokens. If this API key is provided, the SDK will manage the token and handle the refreshing. | |||
| * @param {string} [options.iam_url] - An optional URL for the IAM service API. Defaults to 'https://iam.bluemix.net/identity/token'. | |||
| * @param {string} [options.iam_url] - An optional URL for the IAM service API. Defaults to 'https://iam.ng.bluemix.net/identity/token'. | |||
There was a problem hiding this comment.
This needs to be revised in the generator I think - the default URL is https://iam.bluemix.net/identity/token
There was a problem hiding this comment.
Revised, in all the SDKs. I will open a PR against the template soon
mediumTaj
suggested changes
Jul 12, 2018
|
Comments addressed and unit tests added |
anweshan
approved these changes
Jul 12, 2018
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated the code for this weeks release. Added integration tests for the 5 new Discovery operations.
One of the names of the new discovery operations,
getCredentials()conflicts with thegetCredentials()operation in the base service. I renamed the discovery operation togetSourceCredentials(). If there are other suggestions for that name, I am happy to take them.