docs: add deprecation message for using watson-tokens #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you take a look at why these tests are failing? |
|
Yep, was just starting to look at that |
|
Looks like the tests are just failing because of a timeout, which can probably be fixed with restarting the build. |
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
==========================================
- Coverage 84.11% 84.09% -0.02%
==========================================
Files 35 35
Lines 4324 4325 +1
Branches 548 548
==========================================
Hits 3637 3637
- Misses 318 319 +1
Partials 369 369
Continue to review full report at Codecov.
|
anweshan
approved these changes
Jul 12, 2018
|
Tests passed! |
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the deprecation message in the README, and within the block that checks if the user passed
tokenorwatson-tokenas a query param.