fix: if basic and iam creds given, use iam and dont set basic auth he… #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanattanasio
approved these changes
Jul 24, 2018
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 83.18% 83.19% +<.01%
==========================================
Files 35 35
Lines 4390 4392 +2
Branches 553 555 +2
==========================================
+ Hits 3652 3654 +2
Misses 357 357
Partials 381 381
Continue to review full report at Codecov.
|
anweshan
approved these changes
Jul 24, 2018
|
🎉 This PR is included in version 3.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if multiple forms of credentials were given, the SDK would prioritize the IAM credentials but would still create a header for basic auth or api key auth. This would cause unauthorized errors from the service if the username/password/apikey were invalid.
This PR ignores making that header if IAM credentials are specified. Test is included.