Drop node 4 support #784
Merged
Drop node 4 support #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Node 4 will no longer be supported, considered during development, or tested with. To migrate your code, upgrade to a newer major version of Node.
Codecov Report
@@ Coverage Diff @@
## v4.0.0 #784 +/- ##
=======================================
Coverage 83.27% 83.27%
=======================================
Files 36 36
Lines 4561 4561
Branches 578 578
=======================================
Hits 3798 3798
Misses 362 362
Partials 401 401Continue to review full report at Codecov.
|
germanattanasio
approved these changes
Oct 1, 2018
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Node 4 has officially reached EOL, we should not support it in the next major version of the SDK.
This PR bumps the minimum supported engine to v6 in the
package.jsonfile and removes the Node 4 tests from being run on Travis.I couldn't think of any code that was an artifact of Node 4 restrictions so I didn't change any code. If anyone else knows of something in the code we should change, let me know.