Skip to content

Update vis rec examples #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Update vis rec examples #787

merged 2 commits into from
Oct 4, 2018

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Oct 4, 2018

A user pointed out that the Visual Recognition example should not use api_key now that all of the instances of the service using the old API key authentication have been ended.

This updates the README and the example to prevent further confusion for users.

In the next major version, the code for handling the api_key parameter will be removed (unless you think we should do that now).

cc @SirSpidey

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and supports the service code that's in production

@codecov-io
Copy link

Codecov Report

Merging #787 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files          36       36           
  Lines        4561     4561           
  Branches      578      578           
=======================================
  Hits         3798     3798           
  Misses        362      362           
  Partials      401      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50971c0...e48679d. Read the comment docs.

@dpopp07 dpopp07 merged commit a8c2206 into master Oct 4, 2018
@dpopp07 dpopp07 deleted the update-vis-rec-examples branch October 4, 2018 18:50
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 3.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants