Skip to content

Regenerate sdk release 2 2019 #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 6, 2019
Merged

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Feb 5, 2019

Regenerate the SDKs. Adds new properties for CnC models, new force parameter for STT, new getStopwordListStatus method for Discovery (with tests).

Also fixes a typo @AnthonyOliveri pointed out in the Analytics header.

@dpopp07 dpopp07 requested a review from mediumTaj February 5, 2019 23:00
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good after CI! And anthony has eagle eyes!

@@ -827,6 +851,8 @@ namespace CompareComplyV1 {
/** The content type of file. */
export enum FileContentType {
APPLICATION_PDF = 'application/pdf',
APPLICATION_MSWORD = 'application/msword',
APPLICATION_VND_OPENXMLFORMATS_OFFICEDOCUMENT_WORDPROCESSINGML_DOCUMENT = 'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@mediumTaj
Copy link
Contributor

Tests are failing, did you need to update the test?

Expected: "service_name=conversation;service_version=v1;operation_id=listIntents,async=true"
Received: "service_name=conversation;service_version=v1;operation_id=listIntents;async=true"

@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #833 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files           2        2           
  Lines          46       46           
  Branches        2        2           
=======================================
  Hits           44       44           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce784d...96fc83a. Read the comment docs.

@dpopp07 dpopp07 merged commit dc38567 into master Feb 6, 2019
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 3.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dpopp07 dpopp07 deleted the regenerate-sdk-release-2-2019 branch February 6, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants