Skip to content

fix(speech-to-text): support all allowed parameters in WebSocket method #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Jul 17, 2019

The hand-written WebSocket method for Recognize has gotten out of date with the service. This prevents users from being able to pass in all the parameters that should be supported. This PR adds all currently supported parameters based on the API Documentation for STT.

@dpopp07 dpopp07 requested a review from germanattanasio July 17, 2019 15:34
Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@germanattanasio germanattanasio merged commit e9ef5da into master Jul 17, 2019
@germanattanasio germanattanasio deleted the recognize-websocket-params branch July 17, 2019 15:46
watson-github-bot pushed a commit that referenced this pull request Jul 17, 2019
## [4.2.3](v4.2.2...v4.2.3) (2019-07-17)

### Bug Fixes

* **speech-to-text:** support all allowed parameters in WebSocket method ([b91c1e2](b91c1e2))
* **speech-to-text:** support all allowed parameters in WebSocket… ([#915](#915)) ([e9ef5da](e9ef5da))
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 4.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants