fix: properly store refreshed tokens in websocket libraries #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes a bug that overrided the refresh token with the old token, causing token expirations to be unavoidable
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 53.94% 53.98% +0.04%
==========================================
Files 18 18
Lines 4462 4462
Branches 905 905
==========================================
+ Hits 2407 2409 +2
+ Misses 2053 2051 -2
Partials 2 2
Continue to review full report at Codecov.
|
germanattanasio
approved these changes
Jul 23, 2019
watson-github-bot
pushed a commit
that referenced
this pull request
Jul 23, 2019
## [4.2.6](v4.2.5...v4.2.6) (2019-07-23) ### Bug Fixes * properly store refreshed tokens in websocket libraries ([#920](#920)) ([4b8df28](4b8df28))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves both #849 and #902. I'm sad to say that this is all that was causing the issue - putting the objects into
extend()in the wrong order, causing the refreshed tokens to be overwritten by the old ones. Once the old token expired, no further new connections could be made.Test case added to verify the fix.