fix: extend constructor options types to allow additional properties #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow TypeScript users to use request parameters like the `axios` config properties. we support these in the code but not in the types
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
==========================================
+ Coverage 54.34% 54.38% +0.04%
==========================================
Files 18 18
Lines 4501 4501
Branches 905 905
==========================================
+ Hits 2446 2448 +2
+ Misses 2053 2051 -2
Partials 2 2
Continue to review full report at Codecov.
|
germanattanasio
approved these changes
Aug 5, 2019
this version includes changes for allowing additional properties in the base service constructor
dpopp07
changed the title
watson-github-bot
pushed a commit
that referenced
this pull request
Aug 5, 2019
## [4.3.1](v4.3.0...v4.3.1) (2019-08-05) ### Bug Fixes * extend constructor options types to allow additional properties ([#925](#925)) ([03d241a](03d241a))
|
🎉 This PR is included in version 4.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expose the
axiosconfig options in the constructor but we don't allow any flexibility in the constructor options type. This will allow TypeScript users to use the request parameters like theaxiosconfig properties.Waiting to merge until these changes are made in the core and in the generator.
Edit: generator changes merged in and core version updated to include the corresponding changes.