Skip to content

docs(icp link): fix anchor link to ICP sections #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

jeff-arn
Copy link
Contributor

This fixes the anchor link to the ICP section in the README.

@jeff-arn jeff-arn requested a review from dpopp07 August 22, 2019 00:12
@jeff-arn jeff-arn self-assigned this Aug 22, 2019
@CLAassistant
Copy link

CLAassistant commented Aug 22, 2019

CLA assistant check
All committers have signed the CLA.

@dpopp07 dpopp07 mentioned this pull request Aug 22, 2019
@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #937 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #937      +/-   ##
=========================================
+ Coverage   54.36%   54.4%   +0.04%     
=========================================
  Files          18      18              
  Lines        4505    4505              
  Branches      906     906              
=========================================
+ Hits         2449    2451       +2     
+ Misses       2054    2052       -2     
  Partials        2       2
Impacted Files Coverage Δ
test/resources/auth_helper.js 100% <0%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd648ac...3cf325b. Read the comment docs.

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the change! 👍

@dpopp07 dpopp07 merged commit 795b036 into master Aug 22, 2019
@dpopp07 dpopp07 deleted the docs/fix-icp-link branch August 22, 2019 15:14
dpopp07 pushed a commit that referenced this pull request Sep 13, 2019
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants