Skip to content

build: move snyk to be dev dependency #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

build: move snyk to be dev dependency #974

merged 1 commit into from
Oct 1, 2019

Conversation

MasterOdin
Copy link
Contributor

Moves snyk to be a devDependency as its only usage is in npm run snyk-protect.

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)

dpopp07
dpopp07 approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@dpopp07 dpopp07 merged commit dbd5a14 into watson-developer-cloud:release-v5-rc2 Oct 1, 2019
dpopp07 pushed a commit that referenced this pull request Oct 4, 2019
@MasterOdin @dpopp07
build: move snyk to be dev dependency (#974)
08c7115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterOdin @dpopp07