-
Notifications
You must be signed in to change notification settings - Fork 664
feat: improve typedoc documentation generation #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
=========================================
+ Coverage 77.77% 100% +22.22%
=========================================
Files 1 1
Lines 9 9
Branches 2 2
=========================================
+ Hits 7 9 +2
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ExiliumAeternum This looks really great. I only have one more change I'd like to make:
When a service is selected, the first section to come up after the index is called Type aliases
and defines the callback type. Since we are moving towards callbacks being deprecated, I don't think this should be the first section. Can you move this to the bottom, or remove it?
Also, I'm noticing that the constructor
doc defines the UserOptions
type but doesn't provide a link to view the type itself. This isn't a huge deal, but do you know why this is? I know this type comes from the core, but we document the properties in the comments above the constructor so I feel like we should generate docs for it
@dpopp07 The TSDoc specification shows examples to document only the parameters, not its first level properties. The extra parameters we put in the comment is ignored by TypeDoc since they are not used by the constructor. Like you mentioned, since the type is from the core and not part of the SDK, I don't think TypeDoc found the definition of it and therefore it does not have its own page, and no link to the page either. I've added logic to exclude sections that we are already excluding in the table of content. Please review the PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checklist
npm test
passes (tip:npm run autofix
can correct most style issues)