SVG transforms now complete when fill=none #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <svg width="600px" height="200px"> | ||
| <rect class="expectation" x="190px" y="60px" width="120px" height="120px"> | ||
| </rect> | ||
| <rect class="anim" x="10px" y="10px" width="20px" height="20px" transform="none"></rect> |
There was a problem hiding this comment.
Without transform=none, the animation is still observed to not fill forwards, but the tests fail with transform='null' at times 1_1000 and 1.2_1000
The transforms previously remained in effect, as if the page author had requested fill=forwards https://github.com/web-animations/web-animations-js/issues/605
|
lgtm |
ewilligers
added a commit
that referenced
this pull request
Jun 13, 2014
SVG transforms now complete when fill=none
alancutter
added a commit
to alancutter/web-animations-js-legacy
that referenced
this pull request
Jun 13, 2014
alancutter
added a commit
that referenced
this pull request
Jun 15, 2014
Revert "Merge pull request #606 from ewilligers/svg-transform"
ewilligers
referenced
this pull request
in ewilligers/smil-in-javascript
Jul 7, 2014
We will build our SVG SMIL animation implementation on top of the original Web Animations Polyfill. The only current difference between this implementation and https://github.com/web-animations/ is that we have 'transform' declared as an SVG attribute, using change https://github.com/web-animations/web-animations-js/pull/606 (which was reverted on the main repository as it affects CSS animations that use the transform attribute).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transforms previously remained in effect, as if the page author had
requested fill=forwards
https://github.com/web-animations/web-animations-js/issues/605