-
Notifications
You must be signed in to change notification settings - Fork 132
Firefox is incorrectly marked as not supporting starting-style #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Three options then:
Personally, I'd prefer to go with options 1 or 3. |
I agree that options 1 and 3 would be the best. My leaning is towards #1, but would defer to BCD on what they would prefer. |
See web-platform-dx/web-features#2839 This feature is supported in Firefox, and we don't believe the noted missing functionality is sufficient to make it unusable for authors. In addition the transition from `display:none` is already covered by the `is_transitionable` key: https://github.com/mdn/browser-compat-data/blob/e8988baea037d5a8be014a60d9d928cf7e899f81/css/properties/display.json#L618-L655 so we have an existing record of the gap.
* Remove partial implementation flag from firefox on starting-style See web-platform-dx/web-features#2839 This feature is supported in Firefox, and we don't believe the noted missing functionality is sufficient to make it unusable for authors. In addition the transition from `display:none` is already covered by the `is_transitionable` key: https://github.com/mdn/browser-compat-data/blob/e8988baea037d5a8be014a60d9d928cf7e899f81/css/properties/display.json#L618-L655 so we have an existing record of the gap. * Apply suggestions from code review --------- Co-authored-by: Florian Scholz <[email protected]>
Thank you, @jgraham, for the BCD fix. |
web-features thinks that Firefox doesn't support starting-style because BCD has a partial implementation flag for Firefox, on the basis that it doesn't support animating from
display:none
. However in web-features that functionality is covered by the display-animation feature, and we don't believe it's essential enough to the use cases for starting-style support to be considered blocking.Based on this we should either update BCD to indicate a full implementation of starting-style, or override the result in web-features.
The text was updated successfully, but these errors were encountered: