Skip to content

Firefox is incorrectly marked as not supporting starting-style #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgraham opened this issue Apr 2, 2025 · 3 comments
Closed

Firefox is incorrectly marked as not supporting starting-style #2839

jgraham opened this issue Apr 2, 2025 · 3 comments

Comments

@jgraham
Copy link
Collaborator

jgraham commented Apr 2, 2025

web-features thinks that Firefox doesn't support starting-style because BCD has a partial implementation flag for Firefox, on the basis that it doesn't support animating from display:none. However in web-features that functionality is covered by the display-animation feature, and we don't believe it's essential enough to the use cases for starting-style support to be considered blocking.

Based on this we should either update BCD to indicate a full implementation of starting-style, or override the result in web-features.

@captainbrosset
Copy link
Contributor

Three options then:

  1. Remove the partial implementation flag from BCD.

    I think this is fair, because BCD already tracks animating from display:none in css.properties.display.is_transitionable and css.properties.display.keyframe_animatable, which our display-animation.yml feature is based on.

  2. Do a manual override in web-features.

    To the extent that's possible, we should try to avoid this as it's harder to maintain over time. But it could be, at the very least, a good temporary solution.

  3. Split the css.at-rules.starting-style feature in BCD into two parts:

    • One part that records the existence of the property (this one would be supported everywhere)
    • The other part (a subfeature) which records the support for animating from display:none.

Personally, I'd prefer to go with options 1 or 3.

@jamesnw
Copy link
Collaborator

jamesnw commented Apr 3, 2025

I agree that options 1 and 3 would be the best. My leaning is towards #1, but would defer to BCD on what they would prefer.

jgraham added a commit to jgraham/browser-compat-data that referenced this issue Apr 3, 2025
See web-platform-dx/web-features#2839

This feature is supported in Firefox, and we don't believe the noted missing functionality is sufficient to make it unusable for authors. In addition the transition from `display:none` is already covered by the `is_transitionable` key: https://github.com/mdn/browser-compat-data/blob/e8988baea037d5a8be014a60d9d928cf7e899f81/css/properties/display.json#L618-L655 so we have an existing record of the gap.
Elchi3 added a commit to mdn/browser-compat-data that referenced this issue Apr 4, 2025
* Remove partial implementation flag from firefox on starting-style

See web-platform-dx/web-features#2839

This feature is supported in Firefox, and we don't believe the noted missing functionality is sufficient to make it unusable for authors. In addition the transition from `display:none` is already covered by the `is_transitionable` key: https://github.com/mdn/browser-compat-data/blob/e8988baea037d5a8be014a60d9d928cf7e899f81/css/properties/display.json#L618-L655 so we have an existing record of the gap.

* Apply suggestions from code review

---------

Co-authored-by: Florian Scholz <[email protected]>
@captainbrosset
Copy link
Contributor

Thank you, @jgraham, for the BCD fix.
This issue is now fixed with the release of https://github.com/web-platform-dx/web-features/releases/tag/v2.33.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants