Add discouraged with statement feature

features/symbol.yml

@@ -23,6 +23,5 @@ compat_features:
   - javascript.builtins.Symbol.toString
   - javascript.builtins.Symbol.toStringTag
   - javascript.builtins.Symbol.toStringTag.dom_objects
-  - javascript.builtins.Symbol.unscopables
   - javascript.builtins.Symbol.valueOf
   - javascript.builtins.Symbol.@@toPrimitive

features/symbol.yml.dist

@@ -45,19 +45,6 @@ compat_features:
   - javascript.builtins.Symbol.for
   - javascript.builtins.Symbol.keyFor
 
-  # baseline: high
-  # baseline_low_date: 2016-08-02
-  # baseline_high_date: 2019-02-02
-  # support:
-  #   chrome: "38"
-  #   chrome_android: "38"
-  #   edge: "12"
-  #   firefox: "48"
-  #   firefox_android: "48"
-  #   safari: "9"
-  #   safari_ios: "9"
-  - javascript.builtins.Symbol.unscopables
-
   # baseline: high
   # baseline_low_date: 2016-09-20
   # baseline_high_date: 2019-03-20

features/with.yml

@@ -0,0 +1,24 @@
+name: with
+description: The `with` JavaScript statement adds a given object to the chain of scopes used to evaluate names.
+spec: https://tc39.es/ecma262/multipage/ecmascript-language-statements-and-declarations.html#sec-with-statement
+group: javascript
+discouraged:
+  # One thing that is potentially missing here is a "reason" like this:
+
+  # reason: browser-warning
+  # reason: spec-caution
+  # reason: pending-removal
+
+  # This would allow us to signal to tools how "fatal" the discouragement is
+  # (e.g., pending-removal should trigger noisy errors for developers but spec
+  # caution would not). I'm not sure the full range of these yet; I think it
+  # might be easier to choose the set of reasons after we've enumerated a bunch
+  # of discouraged features.
+  according_to:
+    - https://tc39.es/ecma262/multipage/ecmascript-language-statements-and-declarations.html#sec-with-statement
+  alternatives:
+    - destructuring
+compat_features:
+  - javascript.statements.with
+  - javascript.builtins.Symbol.unscopables
+  - javascript.builtins.Array.@@unscopables

features/with.yml.dist

@@ -0,0 +1,50 @@
+# Generated from: with.yml
+# Do not edit this file by hand. Edit the source file instead!
+
+status:
+  baseline: false
+  support:
+    chrome: "38"
+    chrome_android: "38"
+    edge: "12"
+    firefox: "48"
+    firefox_android: "48"
+    safari: "10"
+    safari_ios: "10"
+compat_features:
+  # baseline: high
+  # baseline_low_date: 2016-08-02
+  # baseline_high_date: 2019-02-02
+  # support:
+  #   chrome: "38"
+  #   chrome_android: "38"
+  #   edge: "12"
+  #   firefox: "48"
+  #   firefox_android: "48"
+  #   safari: "9"
+  #   safari_ios: "9"
+  - javascript.builtins.Symbol.unscopables
+
+  # baseline: high
+  # baseline_low_date: 2016-09-20
+  # baseline_high_date: 2019-03-20
+  # support:
+  #   chrome: "38"
+  #   chrome_android: "38"
+  #   edge: "12"
+  #   firefox: "48"
+  #   firefox_android: "48"
+  #   safari: "10"
+  #   safari_ios: "10"
+  - javascript.builtins.Array.@@unscopables
+
+  # baseline: false
+  # support:
+  #   chrome: "1"
+  #   chrome_android: "18"
+  #   edge: "12"
+  #   firefox: "1"
+  #   firefox_android: "4"
+  #   safari: "1"
+  #   safari_ios: "1"
+  - javascript.statements.with