Skip to content

Bump Node.js to >=20.10.0 #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025
Merged

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Apr 23, 2025

The version must 20.10.0 or later (as opposed to 20.0.0) because we need import attributes, which didn't land until the Node.js 18.19 and 20.10 release lines.

This fixes #2888.

@github-actions github-actions bot added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Apr 23, 2025
@janbrasna
Copy link

With this bump the two import assertions (that would be blocking updates past v21.ish) could be replaced with with safely:

import webSpecs from 'web-specs' assert { type: 'json' };

import webSpecs from "web-specs" assert { type: "json" };

@ddbeck
Copy link
Collaborator Author

ddbeck commented Apr 25, 2025

Thanks for the suggestion, @janbrasna—I've fixed those.

@ddbeck ddbeck merged commit f15485b into web-platform-dx:main Apr 25, 2025
3 checks passed
@ddbeck ddbeck deleted the 2888-bump-nodejs branch April 25, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Node.js to non-EOL release line >18.x
4 participants