Move service worker event to the messageerror feature #2899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event on ServiceWorkerContainer and ServiceWorkerGlobalScope should be given the same treatment for consistency. messageerror shipped after service workers in all features in all browsers, so this seems like the right move, rather than letting the service worker feature have both. The moved event isn't Baseline, so again for consistency exclude both from the compute_from list. This changes some browser versions to be earlier, but doesn't change the Baseline date, determined by Safari.
github-actions
bot
added
the
feature definition
|
This came up in https://chromium-review.googlesource.com/c/chromium/src/+/6486793. |
ddbeck
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event on ServiceWorkerContainer and ServiceWorkerGlobalScope should
be given the same treatment for consistency. messageerror shipped after
service workers in all features in all browsers, so this seems like the
right move, rather than letting the service worker feature have both.
The moved event isn't Baseline, so again for consistency exclude both
from the compute_from list. This changes some browser versions to be
earlier, but doesn't change the Baseline date, determined by Safari.