[Gecko Bug 1846251] Make CSSStyleRule inherit from CSSGroupingRule. #41248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 31, 2023
As per w3c/csswg-drafts#8940. I didn't do this in bug 1837638 because that's what the spec said at the time, that's what other browsers did, and specially because if we did this we had no way of runtime-disable nesting during development or if things went south. This means that we can't keep the nesting pref in 118, but that seems fine (it's already enabled everywhere in 117). Differential Revision: https://phabricator.services.mozilla.com/D184930 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846251 gecko-commit: 62534bac923526d52c2d5f377d00bdf2d34b9a05 gecko-reviewers: peterv, devtools-reviewers
moz-wptsync-bot
force-pushed
the
gecko/1846251
branch
from
5f0d9c4 to
5ad8319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per w3c/csswg-drafts#8940.
I didn't do this in bug 1837638 because that's what the spec said at the
time, that's what other browsers did, and specially because if we did
this we had no way of runtime-disable nesting during development or if
things went south.
This means that we can't keep the nesting pref in 118, but that seems
fine (it's already enabled everywhere in 117).
Differential Revision: https://phabricator.services.mozilla.com/D184930
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846251
gecko-commit: 085c31f150d35371620bb3f884c9f20b396dbe08
gecko-reviewers: peterv, devtools-reviewers