Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Update contract.js #1028

Closed
wants to merge 2 commits into from
Closed

Conversation

MarcoGuarducci
Copy link

Sometimes blockHash is null the second time. You have to wait for the third event

Sometimes blockHash is null the second time. You have to wait for the third event
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.557% when pulling 2f86377 on MarcoGuarducci:develop into 306680f on ethereum:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.557% when pulling 2f86377 on MarcoGuarducci:develop into 306680f on ethereum:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.557% when pulling 2f86377 on MarcoGuarducci:develop into 306680f on ethereum:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.557% when pulling 2f86377 on MarcoGuarducci:develop into 306680f on ethereum:develop.

@@ -117,7 +117,7 @@ var checkForContractAddress = function(contract, callback){
} else {

contract._eth.getTransactionReceipt(contract.transactionHash, function(e, receipt){
if(receipt && !callbackFired) {
if(receipt && receipt.blockHash && !callbackFired) { // sometimes blockHash is null the second time - Marco Guarducci <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please remove your comment here.

@7flash 7flash mentioned this pull request Dec 21, 2017
@nivida nivida closed this Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants