Porting personal.importRawKey, personal.sign, personal.ecRecover from go-ethereum to web3.js #565
Conversation
peculiarity
changed the title
|
Looks good to me - we are supporting |
Well, we will be supporting them later today. |
|
Any idea when we can expect this on the main release? |
|
I don't think anyone maintains this project.. |
|
@frozeman does, I thought. |
|
I'm currently drafting a blog post about this new feature in MetaMask, it would be great to not have to have a note about how web3 hasn't implemented it yet. |
|
At least if it's not maintained anymore, we can have a fork and start maintaining it. |
|
I think Fabian is on a vacation or something (based on his commit history), I'm sure he'll be back soon. |
|
Yeah, sorry for the delay. i was on vacation and very busy on the 1.0 branch, so i didn't put much attention to develop since a while. Merged a bunch now.. |
|
@frozeman cheers |
* bumped version (#865) * validate number of args to solidity functions (#866) * Fix for "filterCreationErrorCallback is not a function" Error #552 (#861) * Missing some checks in order to verify if given value is an object (#568) * make sure the old behaviour is valued in toHex * Porting personal.importRawKey, personal.sign, personal.ecRecover from go-ethereum to web3.js (#565) * Porting personal.importRawKey * Porting personal.sign * Porting personal.ecRecover * Export padLeft and padRight as functions of web3 (#848) I'm working with `bytes12` and it's useful to have these two functions in the web3 object for formatting. * bumped version * fixed lint * new versions file
|
Is it done? |
No description provided.