Remove systemPrompt in favor of the longhand #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just doing the { role: "system", content: ... } version inside initialPrompts fits better with established APIs, and avoids any potential confusion by having both systemPrompt and initialPrompts.
Closes #103.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 5, 2025
Align with explainer removal in favor of initialPrompts longhand: webmachinelearning/prompt-api#106 Add a console warning if used, to be removed in a couple milestones. Fixed: 381974893 Test: Automated; systemPrompt create option ignored (with warning). Change-Id: I553002bd47ce21558bc84ad2c31227551c4f23f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6507421 Reviewed-by: Brad Triebwasser <[email protected]> Commit-Queue: Tom Sepez <[email protected]> Auto-Submit: Mike Wasserman <[email protected]> Reviewed-by: Tom Sepez <[email protected]> Cr-Commit-Position: refs/heads/main@{#1455840}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just doing the { role: "system", content: ... } version inside initialPrompts fits better with established APIs, and avoids any potential confusion by having both systemPrompt and initialPrompts.
Closes #103. @michaelwasserman PTAL!