docs(README): fix warning note about import #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kud
commented
Apr 25, 2017
kud
commented
- Mistake about emoji
- Italic is probably better than quote
- Mistake about emoji - Italic is probably better than quote
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
======================================
Coverage 98.6% 98.6%
======================================
Files 10 10
Lines 359 359
Branches 81 81
======================================
Hits 354 354
Misses 5 5Continue to review full report at Codecov.
|
michael-ciniawsky
requested changes
Apr 25, 2017
README.md
Outdated
| @@ -169,7 +169,7 @@ To disable `@import` resolving by `css-loader` set the option to `false` | |||
| @import url('https://fonts.googleapis.com/css?family=Roboto'); | |||
| ``` | |||
|
|
|||
| > :waning: Use with caution, since this disables resolving for **all** `@import`s, including css modules `composes: xxx from 'path/to/file.css'` feature. | |||
| _⚠️ Use with caution, since this disables resolving for **all** `@import`s, including css modules `composes: xxx from 'path/to/file.css'` feature._ | |||
There was a problem hiding this comment.
italic is a good idea, but please leave the quote :)
:waning: => :warning:
|
Done. I don't know how to rebase and fix via github though. |
michael-ciniawsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.