Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

[v1.0.0-beta.3] Broken parallel option #139

Closed
sapegin opened this issue Oct 10, 2017 · 6 comments
Closed

[v1.0.0-beta.3] Broken parallel option #139

sapegin opened this issue Oct 10, 2017 · 6 comments

Comments

@sapegin
Copy link
Member

sapegin commented Oct 10, 2017

{ parallel: true } work fine but { parallel: { cache: true } } throws an error:

Error: Validation Error

UglifyJs Plugin Invalid Options

options.parallel should be boolean
options.parallel should be integer
options.parallel should match exactly one schema in oneOf
]
  err: 
   [ { keyword: 'type',
       dataPath: '.parallel',
       schemaPath: '#/properties/parallel/oneOf/0/type',
       params: [Object],
       message: 'should be boolean' },
     { keyword: 'type',
       dataPath: '.parallel',
       schemaPath: '#/properties/parallel/oneOf/1/type',
       params: [Object],
       message: 'should be integer' },
     { keyword: 'oneOf',
       dataPath: '.parallel',
       schemaPath: '#/properties/parallel/oneOf',
       params: {},
       message: 'should match exactly one schema in oneOf' } ] }

I also don’t see any change log entries or even commit for this version.

@alexander-akait
Copy link
Member

alexander-akait commented Oct 10, 2017

@sapegin parallel and cache are now difference options, maybe something wrong with schema, in near future i try to investigate, thank you

@sapegin
Copy link
Member Author

sapegin commented Oct 10, 2017

According to the readme, it’s not. It shows both examples as correct: { parallel: { cache: true } } and { parallel: true }.

@sapegin
Copy link
Member Author

sapegin commented Oct 10, 2017

I see, it’s in some random branch. How should I guess that?

@alexander-akait
Copy link
Member

latest beta and branch #108

@sapegin
Copy link
Member Author

sapegin commented Oct 10, 2017

Yes, that’s what I’m saying.

@sapegin sapegin changed the title Broken parallel as a boolean option in 1.0.0-beta.3 Broken parallel option in 1.0.0-beta.3 Oct 10, 2017
sapegin added a commit to styleguidist/react-styleguidist that referenced this issue Oct 10, 2017
@michael-ciniawsky michael-ciniawsky changed the title Broken parallel option in 1.0.0-beta.3 [v1.0.0-beta.3] Broken parallel option Oct 10, 2017
@michael-ciniawsky
Copy link
Member

The options interface changed between beta.2 => beta.3

{ parallel: { cache: 'path/to/cache', workers: 2 } }
=> { cache: 'path/to/cache' , parallel: workers }

to decouple the cache from parallelization

Agreed it should be better visible, but that's up to the release team. Feel free to reopen if still regressions :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants